Adjust random_seed for test_samples_qaoa#136
Merged
Merged
Conversation
t-imamichi
requested review from
manoelmarques,
pbark,
stefan-woerner and
woodsp-ibm
as code owners
Collaborator
Author
|
Need to wait for discussion at Qiskit/qiskit#6424 and Qiskit/qiskit#6425 |
woodsp-ibm
approved these changes
May 18, 2021
Member
woodsp-ibm
left a comment
woodsp-ibm
left a comment
There was a problem hiding this comment.
I approved this on the basis that even if we want the Terra fix for the recent QAOA change merging this will allow CI to continue in the meantime - and this can be altered/changed afterwards again as needed
Collaborator
Author
|
OK. Then I mark it automerge. If Terra's QAOA is fixed, we can revert this PR. |
This was referenced Jul 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Due to Qiskit/qiskit#6396, test_samples_qaoa fails.
https://github.com/Qiskit/qiskit-optimization/runs/2588572261
Qiskit/qiskit#6424 explains some details.
This PR adjust the random seed to pass the unit test.
Fixes #138
Details and comments